search

hiukim / mind-ar-js

Web Augmented Reality. Image Tracking, Face Tracking. Tensorflow.js
MIT License
2.16k stars 399 forks source link

fix: added the video sourceWidth as ar.js #297

Closed turkyden closed 1 year ago

turkyden commented 1 year ago

Added the video sourceWidth and sourceHeight as ar.js

https://github.com/jeromeetienne/AR.js/blob/024318c67121bd57045186b83b42f10c6560a34a/three.js/src/threex/threex-artoolkitsource.js#L188

There are some bug in Huawei P30 Phone:

https://github.com/AR-js-org/AR.js/issues/215

hiukim commented 1 year ago

Thanks for the PR, and sorry for the late reply.

Can you explain what's the underlying issue causing the zoom problem you mentioned? and also, why adding sourceWidth and sourceHeight solved that?