Fix + Failure handling - Githubissues

hiulit / RetroPie-Convert-Videos

A tool for RetroPie to convert videos.

MIT License

12 stars 2 forks source link

Closed edwardsd97 closed 6 years ago

edwardsd97 commented 6 years ago

Fixed issue where first video would go to "converted-"
Added some handling for if the conversion fails
- logs the resulting error code
- renames the result -video.mp4-failed so that the user does not see it as a successful convert and copy it over there valid video with a corrupt one

edwardsd97 commented 6 years ago

Any thoughts on this? If you would rather just leave it be let me know so I can clean out my forked repo.

hiulit commented 6 years ago

Hey, sorry! I didn't have time to check it yet. I'll take a look at it today. At first glance, it looks good :)

hiulit commented 6 years ago

Thanks! I've merged your PR. I've made some little changes:

Added double quotes to $? and $result.
Removed $result when status is FAILED because it will always be 1 and it's not important feedback to the user.
Changed $result to $result_value (because that's what I always use. Personal choice :P)

edwardsd97 commented 6 years ago

Sounds good thanks. Actually I was getting result number 134 or something if I recall. Didn't know what it meant but thats what i was getting.

At any rate. Thanks again for this!

hiulit commented 6 years ago

Thanks to you for bringing this up and for helping me! :D