search

hivdb / sierra

HIVDB Genotypic Resistance Interpretation Program
GNU General Public License v3.0
15 stars 7 forks source link

Added several tests to Utilities.Utilities #16

Closed arodcasanova closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will increase coverage by 1.26%. The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage      78.4%   79.67%   +1.26%     
- Complexity     1274     1304      +30     
============================================
  Files            95       95              
  Lines          6683     6675       -8     
  Branches        615      616       +1     
============================================
+ Hits           5240     5318      +78     
+ Misses         1326     1241      -85     
+ Partials        117      116       -1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/edu/stanford/hivdb/utilities/TSV.java 95.65% <ø> (+95.65%) 11 <0> (+11) :arrow_up:
...in/java/edu/stanford/hivdb/utilities/SeqUtils.java 100% <ø> (+7.14%) 13 <0> (+1) :arrow_up:
...ava/edu/stanford/hivdb/utilities/JdbcDatabase.java 96.66% <ø> (ø) 18 <0> (ø) :arrow_down:
...du/stanford/hivdb/mutations/MutationTypePairs.java 69.69% <ø> (ø) 14 <0> (ø) :arrow_down:
...java/edu/stanford/hivdb/mutations/MutationSet.java 100% <ø> (ø) 95 <0> (ø) :arrow_down:
...java/edu/stanford/hivdb/utilities/MyFileUtils.java 95.83% <ø> (+95.83%) 4 <0> (+4) :arrow_up:
...va/edu/stanford/hivdb/utilities/NumberFormats.java 100% <ø> (ø) 6 <0> (ø) :arrow_down:
...c/main/java/edu/stanford/hivdb/utilities/Json.java 96.29% <ø> (+29.62%) 6 <0> (+4) :arrow_up:
...java/edu/stanford/hivdb/utilities/MyEnumUtils.java 100% <ø> (ø) 6 <0> (ø) :arrow_down:
.../main/java/edu/stanford/hivdb/drugs/DrugClass.java 100% <ø> (ø) 11 <0> (ø) :arrow_down:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f452d9...e8ccce9. Read the comment docs.

philiptzou commented 5 years ago

I guess it's fine since fromGenbank is not really used in production so far.

There are some rebasing issues but it seems to be easy to fix by me. I'll fix it and merge this pull request.