search

hive-engine / hivesmartcontracts

Hive-Engine node software
https://hive-engine.com
MIT License
13 stars 9 forks source link

Only reward witness who produced the round and Use Only Enabled Witnesses For Scheduling #37

Closed Rishi556 closed 9 months ago

Rishi556 commented 1 year ago

Will resolve https://github.com/hive-engine/hivesmartcontracts/issues/36

eonwarped commented 1 year ago

Yeah, change looks fine to me.

bt-cryptomancer commented 1 year ago

@Rishi556 can you advise on status of this item? I believe there were some concerns raised during testing, correct? In which case we should hold off on this for the time being.

Rishi556 commented 1 year ago

Yup, there's some issues related to witness that were discussed which haven't been fixed yet. Best to wait for that to get fixed before merging this in.

bt-cryptomancer commented 1 year ago

Yup, there's some issues related to witness that were discussed which haven't been fixed yet. Best to wait for that to get fixed before merging this in.

Okay, I've changed the PR to draft status for now so that it doesn't get accidentally merged until the issues are resolved.

Rishi556 commented 1 year ago

Small correction: The current problem will continue to happen with this, and in the long term won't lead to differing payouts, but in the short term might have some changes to lower ranking witnesses. Considering that the fix will only require a contract deployment, I still say we wait for that to be done before merging this in.

Rishi556 commented 9 months ago

Will approve after #55 is merged into this.

Completed

bt-cryptomancer commented 9 months ago

Going to merge this now and begin deployment preparations.