hiveeyes / terkin-datalogger

Datalogger for MicroPython and CPython.
https://terkin.org
GNU Affero General Public License v3.0
60 stars 28 forks source link

Some LoRaWAN tests are failing #70

Closed amotl closed 4 years ago

amotl commented 4 years ago

@thiasB just reported that two LoRaWAN tests will fail. He is using Linux Mint 19.3 and Python 3.8.

FAILED test/test_lorawan.py::test_uplink_system_temperature

E       AssertionError: assert bytearray(b'\x00\x01\x00') == bytearray(b'\...\x00\x01\x00')
E         At index 1 diff: 1 != 103
E         Right contains 4 more items, first extra item: 191
E         Full diff:
E         - bytearray(b'\x00g\x01\xbf\x00\x01\x00')
E         ?                 -------------
E         + bytearray(b'\x00\x01\x00')
FAILED test/test_lorawan.py::test_uplink_environmental_sensors

E       AssertionError: assert bytearray(b'\...\x00\x01\x00') == bytearray(b'\...\x00\x01\x00')
E         At index 0 diff: 10 != 0
E         Right contains 8 more items, first extra item: 41
E         Full diff:
E         + bytearray(b'\ng\x01\xe1\x0bg\x01\xe1\x00g\x00\x97\x00s)7\x00h\x9b\x00\x01\x00',
E         - bytearray(b'\x00g\x01\xbf\x00\x02\x01\x80\x01g\x01\xe1\x02g\x01\xe1'
E         -           b'\x03g\x00\x97\x00s)7\x00h\x9b\x00\x01\x00',
E           )
amotl commented 4 years ago

Hi again,

I learned @thiasB was invoking these tests on his branch ttn_mapping already. That's probably the reason the outcomes are deviating.

@thiasB: Invoking these specific tests using

make test-verbose marker=lorawan

will get you a speed gain.

Good luck!

With kind regards, Andreas.

thiasB commented 4 years ago

That's how I do already. But thanks

thiasB commented 4 years ago

I will take care of the tests from now on. The ttn_mapping branch completes the tests successfully now but the latest changes (ADC mocking) still need to get reflected.

amotl commented 4 years ago

I will take care of the tests from now on.

Thanks!