search

hiveeyes / terkin-datalogger

Datalogger for MicroPython and CPython.
https://terkin.org
GNU Affero General Public License v3.0
59 stars 28 forks source link

Add docker-compose configuration for Hiveeyes backend #82

Closed WSt89 closed 3 years ago

WSt89 commented 4 years ago

add hiveeyes-backend-docker-compose

poesel commented 4 years ago

First of all thank you for your contribution!

Here are my thoughts:

Maybe have a more discerning name for 'volumes' - 'dockervolumes'?

This directory should be in .gitignore else it would get committed.

Since there are various .conf and .ini files it may be a good idea to put them into a separate 'docker' directory to keep the amount of clutter in check.

The whole show uses 'make' to run things. So instead of a shell script we need a rule in make. Are you familiar with that? Maybe I can help a bit but I do not know much about it.

WSt89 commented 4 years ago

I agree that moving docker related files into a dedicated folder would be better. I am familiar with using make but haven't created targets yet. However, I can try to integrate it.

poesel commented 3 years ago

Is this now ready to merge?

amotl commented 3 years ago

Dear @WSt89,

thanks a stack for your contribution and apologies for the very late reply. We only recently picked up work on this repository again.

I appreciate your setup very much and love to see the passion you poured into each detail in order to bundle the Hiveeyes backend stack into a concise configuration based on Docker, you even included PutsReq!

However, I feel it doesn't fit well into this repository and started thinking if https://github.com/daq-tools/kotori would be a better place. Nevertheless, I also rejected that idea.

The final outcome from my end was, that it would be definitively worth to dedicate a separate repository to this, just boldly called hiveeyes/hiveeyes-backend-docker. What do you think about this?

With kind regards, Andreas.

amotl commented 3 years ago

Dear Werner,

after finding your original repository [1], we gave this some love and published it to a canonical place at [2]. We also submitted the improvements to https://github.com/WSt89/hiveeyes-backend-docker-compose/pull/2.

As I believe this code found a sweet dedicated place now, I am closing this pull request. Thanks again, this is a very valuable contribution!

With kind regards, Andreas.

[1] https://github.com/WSt89/hiveeyes-backend-docker-compose [2] https://github.com/hiveeyes/hiveeyes-backend-docker