hivemq / helm-charts

HiveMQ Helm charts
http://hivemq.github.io/helm-charts
Apache License 2.0
25 stars 18 forks source link

Setting priority 0 in crd, breaks CD workflow #327

Open sakomws opened 2 months ago

sakomws commented 2 months ago

By default, kubernetes not shows up priority field if it is 0, which breaks CD tooling, assuming its missing the field.

Would be great to remove the priority fields: https://github.com/hivemq/helm-charts/blob/9929ffaae0e21b800486ff4eb1567e7cd21b7d03/charts/hivemq-platform-operator/crds/hivemq-platforms.hivemq.com-v1.yml#L16

here is screenshot from CD tool: Screenshot 2024-09-05 at 15 45 29

afalhambra-hivemq commented 2 months ago

Thanks @sakomws for reaching out to us.

In K8s for a CustomResourceDefinition (CRD), the additionalPrinterColumns columns with a 0 priority are shown in a standard view (kubectl get), however for non-0 priority columns are only shown when -o wide is passed. See:

$ kubectl get hivemq-platforms.hivemq.com hivemq 
NAME       MESSAGE                              STATE         STATEPHASE
hivemq      HiveMQ Platform is ready            RUNNING       READY

$ kubectl get hivemq-platforms.hivemq.com platform -o wide
NAME       MESSAGE                              STATE         STATEPHASE
hivemq     HiveMQ Platform is ready             RUNNING       READY

So when you say kubernetes not shows up priority field if it is 0, what command are you using to display these columns?