search

hivemq / helm-charts

HiveMQ Helm charts
http://hivemq.github.io/helm-charts
Apache License 2.0
25 stars 18 forks source link

ImagePullSecrets missing for webhook and custom resource #37

Open hertfelder opened 3 years ago

hertfelder commented 3 years ago

https://github.com/hivemq/helm-charts/blob/dea201c0175ec5e456abc6b5851fa5a4318db1df/charts/hivemq-operator/templates/hivemq-operator/admission-webhooks/job-patch/job-patchWebhook.yaml#L32-L47

Image for webhook can be specified, but no imagePullSecrets can be given. Most customers depending on changing the image/repo will also have to give credentials for their company container registries.

For the HiveMQ K8s image, imagePullSecrets can be given but there is no hint about that in values.yaml, only in hivemqCluster.json. Would be more user friendly if all possible settings are given in values.yaml (and just commented out).

@patrickjahns

patrickjahns commented 3 years ago

Thank you for reporting this - please feel free to propose the changes as pull-request - thank you :-)