Pattern-based validations need a better UX approach - Githubissues

hivemq / hivemq-edge

HiveMQ Edge is an MQTT gateway that enables interoperability between OT devices and IT systems. It translates diverse protocols into MQTT for streamlined communication and helps organize data into a unified namespace, making managing and streaming data across your infrastructure easier.

http://hivemq.com

Apache License 2.0

106 stars 23 forks source link

Pattern-based validations need a better UX approach #109

Open vanch3d opened 1 year ago

vanch3d commented 1 year ago

Expected behaviour

The error message for the validation of a url field should tell humans what the error is about, not regex parser :-)

Actual behaviour

The standard error message for a pattern attribute of a JSONSchema string is literally transcribing the wronged regular expression. Which, in the case of aurl`, can be long and unreadable, therefore unusable

To Reproduce

Creating an HTTP adapter with an incorrect URL, like in #106

Details

consider the implication for both (or either) backend and frontend validation
human-readable (short?) statement would be better (suggestion, drop the printout of the regex)
in the frontend, consider using destructured validation to pinpoint errors and utilise field-associated error messages:
- the domain xxx is not valid
- the protocol httpxyz is not valid

simon622 commented 1 year ago

I will ensure that the HTTP adapter uses the URL format and the pattern is removed