search

hivemq / hivemq-edge

HiveMQ Edge is an MQTT gateway that enables interoperability between OT devices and IT systems. It translates diverse protocols into MQTT for streamlined communication and helps organize data into a unified namespace, making managing and streaming data across your infrastructure easier.
http://hivemq.com
Apache License 2.0
92 stars 21 forks source link

feat(19819): Add safeguard and feedback to the deletion of items in the data hub tables #301

Closed vanch3d closed 4 months ago

vanch3d commented 4 months ago

See https://hivemq.kanbanize.com/ctrl_board/57/cards/19819/details/

The PR adds the confirmation dialogue to the deletion of items in the policy, script and schema tables, to ensure deletion doesn't occur by mistake (they are non-reversible).

Upon confirmation, the usual toast confirms the deletion of the item or shows any error.

Before

screenshot-localhost_3000-2024 03 01-12_33_39

After

screenshot-localhost_3000-2024 03 01-12_34_40

screenshot-localhost_3000-2024 03 01-12_34_52

oli-hivemq commented 4 months ago

With this PR, a user would have to confirm their action, which would mean requiring an extra step. It's ok for now but I started a discussion in #guild-frontend-design-system about replacing this behaviour with a way to undo an action. CleanShot 2024-03-04 at 13 03 23

If the dialog remains, the dialog page on zeroheight shows a list of Do and Don't for the button styles. If it's easy to do, I would suggest updating the button styles on the dialog.

sfrehse commented 4 months ago

There are excellent discussions in slack about this topic. Let's derive some basic requirements on the backend to drive that from the ground up.

vanch3d commented 4 months ago

If the dialog remains, the dialog page on zeroheight shows a list of Do and Don't for the button styles. If it's easy to do, I would suggest updating the button styles on the dialog.

Will start aligning with the design system on the next open source release. Button change is easy but requires a cascade of changes on other elements (colors in particular)