search

hivemq / hivemq-edge

HiveMQ Edge is an MQTT gateway that enables interoperability between OT devices and IT systems. It translates diverse protocols into MQTT for streamlined communication and helps organize data into a unified namespace, making managing and streaming data across your infrastructure easier.
http://hivemq.com
Apache License 2.0
91 stars 20 forks source link

fix(21009): Add navigation to the error node's panel #376

Closed vanch3d closed 2 months ago

vanch3d commented 2 months ago

See https://hivemq.kanbanize.com/ctrl_board/57/cards/21009/details/

The PR fixes the missing navigation to the configuration panel of a node flagged as an error in the validation check.

Every node in a verified policy with an error in the report provides access to both its location in the Designer and to its configuration side panel.

After

screenshot-localhost_3000-2024 04 15-10_56_44

vanch3d commented 2 months ago

I've made changes according to your suggestions.

suggestion: Assuming that as Edge grows, more time-based interactions and timeouts will keep appearing. For consistency, I suggest defining time constants that you'll be able to reuse

I've created a constant for it, in a placeholder that should be used to similar values. But I also think they should be part of the theme (and design system), as part of the consistent UX we are building across our product. ChakraUI already provides a good framework through its theme tokens for defining such constants, see https://v2.chakra-ui.com/docs/styled-system/css-variables