search

hivemq / hivemq-mqtt-client

HiveMQ MQTT Client is an MQTT 5.0 and MQTT 3.1.1 compatible and feature-rich high-performance Java client library with different API flavours and backpressure support
https://hivemq.github.io/hivemq-mqtt-client/
Apache License 2.0
860 stars 159 forks source link

Added custom http headers to MqttWebSocket #500

Closed hctemmel closed 1 year ago

hctemmel commented 3 years ago

Motivation Added the option to add custom http headers (eg bearer token authentication to reverse proxy) for websocket connection

Changes MqttWebSocketConfig

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

SgtSilvio commented 3 years ago

@hctemmel Thank you for your contribution. It seems to be pretty good, but before we can review and incorporate it, you need to sign our CLA. Please follow the instruction of the cla-bot's comment. If something is unclear please just ask.

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

skrutzler commented 2 years ago

It took a while but the CLA is now signed and was sent to contributing@hivemq.com

skrutzler commented 2 years ago

Hello @SgtSilvio. Do you need anything else from my side to start the review process? Thanks a lot and best regards.

SgtSilvio commented 2 years ago

@cla-bot check

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!

SgtSilvio commented 2 years ago

Sorry, please ignore the above messages from the cla-bot, I need to check who has access to contributing@hivemq.com

MagiErber commented 2 years ago

@cla-bot check

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!

MagiErber commented 2 years ago

Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you!

skrutzler commented 2 years ago

Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you!

Hello. My username (preto) was on the signed CLA. skrutzler is just the changed nickname and belongs to the same registered user ( click on my profile to see it ;) @skrutzler ) I guess it would take me another 3 months with my employee legal department to get an updated document ...

SgtSilvio commented 2 years ago

@skrutzler I am very sorry for the delay. The easiest way would be to remove your commit, as it is an empty merge commit anyhow. Rebasing your branch on master should remove this commit. I can also help to do that once I find the time for it. Unfortunately we can not add preto to the CLA list, as this is actually your nickname and skrutzler is your username/profile on GitHub.

skrutzler commented 1 year ago

@cla-bot check

cla-bot[bot] commented 1 year ago

The cla-bot has been summoned, and re-checked this pull request!

skrutzler commented 1 year ago

@SgtSilvio I think all requirements are met now and it can be merged if there are not any remarks.

Do you know by any chance when a new release with those changes might be triggered?

skrutzler commented 1 year ago

is there anything still missing on our end @SgtSilvio ?

pglombardo commented 1 year ago

Hi @skrutzler - thanks for staying on top of this and traversing the cla bot. Either I or @SgtSilvio will take a look at this very soon and post an update.

pglombardo commented 1 year ago

Thanks for your work and patience on this @skrutzler! PR is merged. We'll put out a new release soon.