hivemq / hivemq-mqtt-client

HiveMQ MQTT Client is an MQTT 5.0 and MQTT 3.1.1 compatible and feature-rich high-performance Java client library with different API flavours and backpressure support
https://hivemq.github.io/hivemq-mqtt-client/
Apache License 2.0
824 stars 153 forks source link

Upgrade Netty to 4.1.99.Final #590

Closed wborn closed 9 months ago

wborn commented 10 months ago

Description

This upgrades Netty to address:

It also fixes a bug when using JDK21+.

Related Issue

Closes #503

Type of Change

Checklist

cla-bot[bot] commented 10 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

wborn commented 10 months ago

I can do the CLA if it is really neccessary for this one line change. Let me know if you consider merging this PR, so I don't have to waste my time on the CLA. :wink:

cla-bot[bot] commented 10 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] commented 10 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

wborn commented 10 months ago

The CLA is pending and I updated to 4.1.97.Final. :rocket:

https://netty.io/news/2023/08/23/4-1-97-Final.html

cla-bot[bot] commented 10 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] commented 9 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

wborn commented 9 months ago

In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added.

I already did that weeks ago @cla-bot. :wink:

pglombardo commented 9 months ago

Hi @wborn - CLABot has some personality issues. :-)

Thanks for pointing this out. Just for this change that points out a new version number, the CLA isn't a blocker. I'll look to merge the change this week. Thanks again!

cla-bot[bot] commented 9 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

wborn commented 9 months ago

There's a 4.1.99.Final now that also fixes a bug on JDK21+:

https://netty.io/news/2023/09/21/4-1-99-Final.html

pglombardo commented 9 months ago

Thanks @wborn - I'll put out a new release soon!

pglombardo commented 9 months ago

Release 1.3.3 is out!

wborn commented 9 months ago

Thanks a lot @pglombardo! :+1: