Fix pymongo version parsing

hivesolutions / appier

Joyful Python Web App development

http://appier.hive.pt

Apache License 2.0

126 stars 22 forks source link

Fix pymongo version parsing #51

Closed NFSS10 closed 2 years ago

NFSS10 commented 2 years ago

Issue:

Pymongo released version 4.0 on november 29 2021 and unlike the others version, this one doesn't event the patch number so as appier is assuming that pymongo will have a patch number, it fails to unpack that value and an error is thrown.

Replicating the issue:

Testing the fix:

coveralls commented 2 years ago

Coverage decreased (-0.8%) to 63.145% when pulling 8f393ccbbdcfdb06947ab90c084b41eb7498f08f on NFSS10:ns/fix_pymongo_version_parsing into 5074b27c182e2fadcc2220d867753567cd2f62f5 on hivesolutions:master.

coveralls commented 2 years ago

Coverage decreased (-0.8%) to 63.138% when pulling 8f393ccbbdcfdb06947ab90c084b41eb7498f08f on NFSS10:ns/fix_pymongo_version_parsing into 5074b27c182e2fadcc2220d867753567cd2f62f5 on hivesolutions:master.

joamag commented 2 years ago

Fixed by https://github.com/hivesolutions/appier/commit/69a4a7cddd6b120fb12cbb3ec4da39c8e9e2032a