search

hivesolutions / shopify-api

API client for the Shopify service
http://shopify-api.hive.pt
1 stars 4 forks source link

Deprecation of Shopify's `Metafield.valueType` #19

Closed joao-conde closed 1 year ago

joao-conde commented 1 year ago

Rationale

This API client becomes unusable for the latest Shopify API version. It is business critical that this is compliant with their new API while maintaining retro-compatibility with other API versions.

Description

The latest version of the Shopify API will deprecate the field Metafield.valueType in favor of Metafield.type.

Implementation

Software development

Change:

To accept both value_type and type as kwargs and set the metafield dictionary with type = VALUE thus maintaining retro compatibility.

Reference

image

joamag commented 1 year ago

@joao-conde go ahead create a fork and make the changes :)

joamag commented 1 year ago

@joao-conde also, if there's a URL describing the deprecation (on the Shopify doc side) please add it to the description for future reference

joao-conde commented 1 year ago

@joamag added what I could find, the rest is a company private email which even I dont have access to.

joamag commented 1 year ago

found another reference to this topic https://shopify.dev/apps/metafields/migration

joamag commented 1 year ago

Releasing 0.6.5 with this fix. Closing this issue.