hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

unprovoked whitespace on right of UI #103

Closed timoxley closed 10 years ago

timoxley commented 10 years ago

image

haustraliaer commented 10 years ago

Do you think that's the scrollbar (but on a page with not enough content to actually scroll)?

If that is the scrollbar causing the whitespace then it's intentional to avoid the screen jumping between widths as you navigate between a view with scroll and a view without.

timoxley commented 10 years ago

@haustraliaer you know what… it is the scroll bar. My bad, though even with many years of scrolling experience under my belt, I did not recognise it.

Personally, I don't mind the jump since it's a cue that indicates scrolling is now possible. People tend to see the scroll bars as part of the browser rather than your app, so you might not need to be so concerned about dictatoring it. IMO a jumpy but familiar scroll bar behaviour is better than a "what is this weird whitespace?" experience.

Looking through the content, the only place the UI is likely to need scroll is on the history page. Perhaps scrolling could be added just to the .content that needs it.

timoxley commented 10 years ago

e.g. untitled-2

haustraliaer commented 10 years ago

Definitely something I've thought about. It's generally pretty unsafe to do that with a responsive project as you'll be effectively forcing the window (html element) to overflow: none in order to get that behaviour. Perhaps the nature of this app (not generally long pages) will allow for it though.

haustraliaer commented 10 years ago

Executive decision to leave the overflow-y set to scroll for now as we focus on iOS, sorry Tim.