Firefox bugs - Githubissues

hivewallet / hive-js

Hive digital currency wallet

http://www.hivewallet.com

GNU General Public License v2.0

81 stars 57 forks source link

Firefox bugs #111

Closed haustraliaer closed 10 years ago

haustraliaer commented 10 years ago

Started a new branch to fix some obvious firefox bugs that I've found: https://github.com/hivewallet/hive-js/tree/hotfix/ff

[x] overlays can't close with click (escape still works)
[x] inputs require a height value otherwise text is hidden

haustraliaer commented 10 years ago

Fixed overlays with: https://github.com/hivewallet/hive-js/commit/156ea45ddc4f27485dfad51b5a0678c512d78dd4

Firefox was returning: TypeError: event.original.srcElement is undefined

Not sure if the conditional was necessary for other features? It seemed like it blocked the modals from being closed by tapping the actual modal content box (which was a desired behaviour anyway).

haustraliaer commented 10 years ago

Fixed inputs: https://github.com/hivewallet/hive-js/commit/1f5e0670593f2a3aa688213c3e8fab5b16f81ef3

Leaving open until @weilu confirms we don't need the conditionals: https://github.com/hivewallet/hive-js/commit/156ea45ddc4f27485dfad51b5a0678c512d78dd4

or comes up with something else.

weilu commented 10 years ago

See comment on the referenced commit

haustraliaer commented 10 years ago

@weilu sure but is there a way we can write it differently? Firefox breaks hard on getting the event.original.srcElement.

weilu commented 10 years ago

we can check if event.original is undefined before we call srcElement on it

haustraliaer commented 10 years ago

Ok I sorted it found out firefox was using originalTarget instead of srcElement...

https://github.com/hivewallet/hive-js/commit/c6b08456ba53