hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Better error messages across the app #112

Closed mackuba closed 9 years ago

mackuba commented 10 years ago

Right now I see: "Whoops! auth_failed".

Also, why is it asking me for a pin when I've just entered the full 12-word passphrase?

haustraliaer commented 10 years ago

We haven't had time to establish a decent user flow for not having a pin yet, so a pin is required for all accounts at this stage. We force it so the user doesn't have to enter in their passphrase again if they accidentally refresh, or leave the app.

haustraliaer commented 10 years ago

Changed title to generalise issue (there are a few places the error messages are inadequate).

jenbennings commented 10 years ago

Also, why is it asking me for a pin when I've just entered the full 12-word passphrase?

I agree, this needs to be improved. At the bare minimum we should change the wording to reflect when there is no PIN attached to the wallet. E.g. "Set your PIN for this device". I will look into this as part of #82.

The question of whether a PIN is attached to my wallet in the same way the passphrase is will definitely come up, so we should try and solve this too (whether it is part of the on-boarding process or the FAQ).

weilu commented 10 years ago

Also, why is it asking me for a pin when I've just entered the full 12-word passphrase?

It's because you set up the wallet somewhere else with a pin. The pin is needed to exchange the long token with the server so that your personal details get synced on the device you currently wants to open your wallet on

mackuba commented 10 years ago

It's because you set up the wallet somewhere else with a pin. The pin is needed to exchange the long token with the server so that your personal details get synced on the device you currently wants to open your wallet on

Ah, right, I forgot about that - I thought that if I log in to a wallet with no previous cookies set, I'd set a new pin for that device. Another potential point of confusion for the users, I guess ;)

weilu commented 10 years ago

Indeed. That's why @jenbennings opened https://github.com/hivewallet/hive-js/issues/65 and started https://github.com/hivewallet/hive-js/wiki/Hive-Web-FAQ. Still work in progress. Feedback welcome :)

mackuba commented 10 years ago

"insert metaphor here" -> http://www.reddit.com/r/Bitcoin/comments/27zbwj/thats_a_lot_of_bitcoin_addresses_one_way_to/

mackuba commented 10 years ago

Q: "Why does Hive ask me for an existing PIN when I log in to the wallet using the passphrase on a new device"

weilu commented 10 years ago

Feedback from Andy Megavand:

Quick bug report: if your iPhone is set to not allow Safari access to location services, the message in the wallet when you try to receive using waggle is "We couldn't connect you to Waggle, please check your internet connection'". Perhaps it could mention that the reason may be due to privacy settings.

haustraliaer commented 10 years ago

Ideally we should check if they have enabled location services and the prompt them again if not - I'm not sure how possible that is from the browser, but would be much better than requiring them to do it in their OS settings.

weilu commented 10 years ago
ghost commented 10 years ago

"Q: "Why does Hive ask me for an existing PIN when I log in to the wallet using the passphrase on a new device""

That's a good question -- why does it do that?

jenbennings commented 10 years ago

@w-hive https://github.com/hivewallet/hive-js/wiki/Hive-Web-FAQ#why-am-i-asked-for-a-pin-when-i-log-in-to-an-existing-wallet-on-a-new-device

ghost commented 9 years ago

Error messages to be greatly improved in Hive 2.0. Closing for now.