hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Inadequate Error Message when sending whole balance. #122

Closed dabura667 closed 10 years ago

dabura667 commented 10 years ago

When user tries to send the whole balance, the error message "Not enough funds" comes up.

A new user who has yet to learn of mining fees will be perplexed. So if send amount = balance, and fee is required, display "This transaction requires a miner's fee. The most you can send after paying the miner's fee is (balance - 0.0001)."

Or you could get fancy and maybe have a "Would you like to send (balance - 0.0001) BTC instead?" with a Yes No selection.

Basically, as long as the user understands why they can't empty their wallet, this would be solved.

weilu commented 10 years ago

updated (fixed typo & make animation repeat): What I've got now:

empty-wallet

@haustraliaer @jenbennings thoughts?

haustraliaer commented 10 years ago

Typo: "...your can send".

But otherwise, yep seems fine.

jenbennings commented 10 years ago

I'm fine with this.

Perhaps a simpler alternative may be: "It looks like you're trying to empty your wallet..." warning, followed by a confirm/cancel button which goes straight to the confirm modal, as opposed to throwing the user back to the send panel again?

Edit: Ehhh... Actually I'm happier with what @weilu currently has.

weilu commented 10 years ago

@jenbennings I started with that. But it would require passing the state across 3 views (the info flash alert + the confirmation panel + the send panel, in case user cancels the send). And the flash alert needs to be upgraded into a prompt which handles "yes" and "no". Overall, I think the work doesn't justify the UI benefit...

ghost commented 10 years ago

Does that second confirm box ONLY appear when the amount is a significant % of total token in the wallet?

haustraliaer commented 10 years ago

Pretty sure it only appears if you try and spend more than your balance, aka 100% of the total token (without allowing for the miners fee).