search

hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Turn off Waggle feature when changing receiving/sending #125

Closed KBenavidez closed 10 years ago

KBenavidez commented 10 years ago

People tend to forget to turn Waggle off for receiving bitcoin when they are about to send bitcoin. This tend to make them visible all the time and make their battery low. Maybe you guys can do an automatic waggle off when the user leaves the receive/ send button.

haustraliaer commented 10 years ago

I was thinking about this earlier, probably a good idea.

ghost commented 10 years ago

Or maybe a global indicator?

haustraliaer commented 10 years ago

Waggle should turn itself off if you leave the app, and in the edge case that it doesn't - I think @weilu is going to do a sweep of lingering location data and remove it ever 30 mins or so.

I'd be kind of annoyed if I (for some reason) wanted to leave waggle on broadcast mode while using other areas of the app, but couldn't.

What if we made the receive tab flash (like the waggle title when on the tab) once you leave that tab?

cc: @jenbennings

weilu commented 10 years ago

The periodic sweeping of geo data is done. Currently it cleans up data older than 4 hours. The job runs every 4 hours. So any geo data will not stick around for longer than 8 hours. Note that the periodic sweeping only applies to production, as we don't need it for local dev + the code is cleaner this way.

haustraliaer commented 10 years ago

I still think it's worth flashing the receive tab (icon and title) while waggle is active - unless anyone has a serious problem with this I'll implement and close this issue cc: @weilu @jenbennings @mattatgit

mattatgit commented 10 years ago

i think we'll be ok without flashing anything else. We already have a flashing "broadcasting location" and yellow button "turn it off". I think that is enough. People may want to jump out of that tab while they are waiting for others to connect anyway..

weilu commented 10 years ago

I don't think flashing is great idea because it could mean many things, like in the case of a flashing receive tab it could be "I have a pending incoming transaction", or "I have not tried clicking on the receive tab", or "I have not tried waggle" etc. What it actually means needs to be learnt. Switching it off when user has moved away from current tab (including clicking on other tabs and opening the drawer) just seems simpler. It takes almost no effort to switch on waggle anyway in case user accidentally clicked away.

haustraliaer commented 10 years ago

Based on the collective feedback for this issue I'm gonna make the call that we don't need to turn this off if the user switches tabs, nor do we particularly need an indicator if the database is going to be flushed every 4 hours.