search

hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

While it's generating a passphrase, click on back and wait for it.... the generated passphrase shows up anyway #145

Closed ghost closed 10 years ago

ghost commented 10 years ago

If I let it generate a key for me, it takes a long time. But actually if I click go back and then click generate again, it appears immediately, indicating that it was probably already generated.

ghost commented 10 years ago

We saw this issue on some Android devices too, in HK.

haustraliaer commented 10 years ago

There was one part of the UI I removed the back button for this reason - but I think it was after reviewing the pass phrase (key). We're still looking into better UI ideas for the long load/generation times.

ghost commented 10 years ago

I think you missed the point I was making: It obviously finished generating, but it never told me.

haustraliaer commented 10 years ago

Hmmm, possibly it's doing something else on top of generating the key? And then waiting until everything is done before revealing it.

Have to get @weilu to comment on this one.

weilu commented 10 years ago

I think it's related to https://github.com/hivewallet/hive-js/issues/146#issuecomment-47469167. I haven't seen this on android. How many people out there has 3GS?

ghost commented 10 years ago

Have seen this repeatedly now. Also had the same effect on a Qmobile Noir A35 (Android, probably "Jelly Bean" / 4.2).

weilu commented 10 years ago

It's not specific to any device. It's the way we do "render on callback done". You can verify it by starting a passphrase generation then click on back and leave it. You will see the passphrase page pops up in a bit.

We should hide/disable the back link while passphrase generation is in progress.

Updated the ticket name.

ghost commented 10 years ago

I tested it a few times using the 5 minutes / 30 seconds routine from #146 ... It definitely is generating it and simply not changing the screen.

weilu commented 10 years ago

That could be a different issue (for example, web worker not working properly on your testing device). I cannot verify that because I don't have a 3GS. The steps I described above can be verified on chrome & safari.

weilu commented 10 years ago

Also #146 is not even about generating passphrase, it's about setting pin

haustraliaer commented 10 years ago

I've removed the back button when generating pin - which seems to be the main point of this issue (and needed to be done anyway). https://github.com/hivewallet/hive-js/commit/e8610649dbfc

ghost commented 10 years ago

@weilu I meant this "routine", the routine of waiting. :) https://github.com/hivewallet/hive-js/issues/146#issuecomment-47635973

ghost commented 10 years ago

@haustraliaer That isn't the point of this issue. It's about the fact that the next screen never shows up.

haustraliaer commented 10 years ago

Well that was still an issue, which I've now fixed. Other issue is now consolidated here: https://github.com/hivewallet/hive-js/issues/147