search

hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Waggle displaying wallets with no name #169

Closed jenbennings closed 10 years ago

jenbennings commented 10 years ago

To clarify, if I create a new wallet, search for someone else (without adding a name), I will be visible to others using Waggle as above (avatar with no name).

weilu commented 10 years ago

@javgh There's an API change to the geo endpoints. POST /location used to upload location data and return the search results. As where our current UI stands where recipient is the broadcaster who doesn't need to see the sender, while the sender only needs to search. So I have separated the search and save of geo data into two separate endpoints:

POST /location saves geo data for search. On success returns 201, failure returns 400 with json error PUT /location searches geo data for nearby users. On success returns 200, failure returns 400 with json error (I know, not the best use of PUT. I started with GET but then realized that the client will need to convert the json params into query strings. So meh)

The request JSON body remains the same. @javgh please let me know when you have migrated Android client code to use the new endpoints. We can then coordinate a new release together.

weilu commented 10 years ago

@javgh Staging has the updated geo endpoints. You can test against that. We are aiming at submitting the ios app by the end of this week, so shall we fix a time for deployment this Friday?

javgh commented 10 years ago

@weilu: Friday is fine with me. You can pick a time that works for you and I'll push out an update then.

Also: Am I reading the code right, that it's now also possible to update my own location by calling POST /location again with the cookie already set?

weilu commented 10 years ago

Yes, it will just overwrite the geo data on server with the new ones passed in.