hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Confirm modal for switching currencies #171

Closed haustraliaer closed 10 years ago

haustraliaer commented 10 years ago

Now that our currencies are in the main part of the app I think we should create a pop-up to confirm before switching tokens to avoid user irritation.

weilu commented 10 years ago

But the users already need to tap to the tokens tab, then tap on the token that he/she isn't currently using. I don't think it's likely to switch tokens by mistake. Also, remember good old windows asking you "Are you sure?"

haustraliaer commented 10 years ago

Yeah, but this action causes a full refresh on the app - not something to be taken lightly. If we do end up having lots of tokens (which is the plan as far as I know) then there will be a list of tokens to scroll through.

And given that sometimes fastclick will pick up a touch event if the scroll action isn't definitive enough - I think this is a wise idea.

weilu commented 10 years ago

Let's revisit this issue when we do have a lot of tokens. We might even want to only keep the last used screenful of tokens for display and supply a search field, in which case scrolling wouldn't be necessary.

haustraliaer commented 10 years ago

Sure, no problem will close this for now.