search

hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Safari 7 and 8 iDB issue fix using websql #221

Closed genecyber closed 9 years ago

weilu commented 9 years ago

@genecyber we don't always want to use websql as the backing db -- we'd want to use IndexedDB in browsers that has support for it. Did you find out what's the root cause for safari 8 db issue? Is pouchDB detecting the wrong database?

genecyber commented 9 years ago

It's an actual bug in safari 7 and 8 that's not expected to be fixed. I can add a more complicated check but I opted not to add complexity over just switching to the works everywhere websql. Why use pouch where available?

On Sat, Dec 6, 2014 at 7:09 AM, Wei Lu notifications@github.com wrote:

@genecyber we don't always want to use websql as the backing db -- we'd want to use IndexedDB in browsers that has support for it. Did you find out what's the root cause for safari 8 db issue? Is pouchDB detecting the wrong database?

Reply to this email directly or view it on GitHub: https://github.com/hivewallet/hive-js/pull/221#issuecomment-65894707

weilu commented 9 years ago

It's an actual bug in safari 7 and 8 that's not expected to be fixed.

Can you link me to more details regarding this? Also note that the app works in safari 7 but not 8. So if this is due to a bug for both versions then does this PR actually fix anything?

genecyber commented 9 years ago

Surprisingly the app works fine in safari 8 if the user saves the site to the home screen. Yes my patch fixes the issue in ios8 I'll have to look up details to send. http://pouchdb.com/adapters.html

It looks like pouch has been updated to detect the safari issue and fail gracefully.

On Sat, Dec 6, 2014 at 7:15 AM, Wei Lu notifications@github.com wrote:

It's an actual bug in safari 7 and 8 that's not expected to be fixed.

Can you link me to more details regarding this? Also note that the app works in safari 7 but not 8. So if this is due to a bug for both versions then does this PR actually fix anything?

Reply to this email directly or view it on GitHub: https://github.com/hivewallet/hive-js/pull/221#issuecomment-65894862

weilu commented 9 years ago

I can add a more complicated check but I opted not to add complexity over just switching to the works everywhere websql.

WebSQL is deprecated (See: http://dev.w3.org/html5/webdatabase/ and https://hacks.mozilla.org/2010/06/beyond-html5-database-apis-and-the-road-to-indexeddb/). Moving forward we definitely want to be on indexedDB as much as possible.

weilu commented 9 years ago

Upgrading pouch fixed it. Thank you for looking into this @genecyber