hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

With Blockchain.info recent issues, how secure is our wallet generation? #222

Closed pennyfx closed 9 years ago

weilu commented 9 years ago

We don't write our own rng nor use Math.random. We make it a point to only support browsers that come with crypto.getRandomValues. The entropy is then used to generate the mnemonic and seed as described in BIP39. BIP39 https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki, The javascript implementation we use: https://github.com/weilu/bip39/blob/master/index.js

Side note, blockchain.info started off with an old version of bitcoinjs-lib and they've been since maintaining their own version of the library. We are tracking the stable releases of bitcoinjs-lib which has long abandoned the rng.js file: https://github.com/bitcoinjs/bitcoinjs-lib/pull/36