search

hivewallet / hive-js

Hive digital currency wallet
http://www.hivewallet.com
GNU General Public License v2.0
81 stars 57 forks source link

Auth without PIN setting #40

Closed haustraliaer closed 9 years ago

haustraliaer commented 10 years ago

For people who are not worried about this specific security layer and want the convenience - we should allow them to open the wallet on a given device without a PIN once the passphrase has been entered.

I think this should be a localStorage reference per device, rather than setting it for all devices the way we set the PIN.

jenbennings commented 10 years ago

+1

mackuba commented 10 years ago

I think the wallet does currently let me set an empty pin, but it seems more like an accident than a feature ;)

weilu commented 10 years ago

@jsuder pin validation is absent indeed. created an issue: https://github.com/hivewallet/hive-js/issues/45

haustraliaer commented 10 years ago

Yep I've been using that for convenience in development - but this proposal is to let the user do away with the auth screens entirely, if they so choose to.

weilu commented 10 years ago

Implementation so far should be sufficient for disabling pin in dev environment. Reads: not user friendly - currently 1) upon successful pin disable, wallet reloads. 2) after disabling pin, one is still presented with the pin screen and they need to click on the "Open wallet" button to get int.

Will polish the UI when this feature is scheduled to release for realz

ghost commented 9 years ago

Closing for now, likely won't be something we address in this version of Hive.