hivewallet / hiveapp-bitstamptrader

Hive application for Bitstamp trading
MIT License
1 stars 3 forks source link

Denomination #2

Closed weilu closed 10 years ago

weilu commented 10 years ago

Make bitstamp app respect user's btc denomination as per requested: https://github.com/tgerring/hiveapp-bitstamptrader/issues/11

before login

after login

ghost commented 10 years ago

Just make sure that fits with the minimum supported width of the Hive window (which I would recommend you use as the default view during testing).

weilu commented 10 years ago

Like so? screen shot 2014-01-24 at 8 36 10 am Or maybe screen shot 2014-01-24 at 8 38 47 am

ghost commented 10 years ago

First one is good.

But try it in the minimal Hive window width. :)

weilu commented 10 years ago

screen shot 2014-01-24 at 9 10 12 am

tgerring commented 10 years ago

@weilu If you apply the nowrap class to the Last cell (as I did with volume), does that prevent wrapping at minimum width?

tgerring commented 10 years ago

Hrm, looking at the volume adjustment, I don't know how smart this is... it could cause massive confusion if we say volume is 1000x what it actually is just due to the user preferred currency. Doesn't seem right.

@jsuder what do you think?

mackuba commented 10 years ago

Hmm, you might be right, I'd show a unit with the volume.

tgerring commented 10 years ago

It makes me think that form a larger perspective, we shouldn't mess with the values quoted at the top... only the user values in the bottom tabs related to input, etc.

weilu commented 10 years ago

nowrap on td does it screen shot 2014-01-24 at 9 18 36 am

@tgerring yea... the volume was one of the reasons why I pulled the unit out as a separate column. I kind of agree that the board prices should be in BTC, like in a FX market. @w-hive thoughts?

ghost commented 10 years ago

Looks fine to me.

weilu commented 10 years ago

We will leave the value quoted at the top (the ticker prices) for now. If more than 1 user complains about the inconsistency, we will revisit the design.