hiweller / recolorize_examples

8 stars 3 forks source link

Fatal error on line 32 in snake example #1

Closed mhackett324 closed 2 years ago

mhackett324 commented 2 years ago

Hi!

I love the package so far and have been working through the examples using RStudio v1.4.1106 with R v4.1.0. However, when I reached the snake example, specifically the last line, R aborts on me. No issues with installation and no other issues with the rest of the example.

Thanks, Matt

hiweller commented 2 years ago

Ooh, thanks Matt. I’ll look at this today.

On Thu, Jun 2, 2022 at 08:35 mhackett324 @.***> wrote:

Hi!

I love the package so far and have been working through the examples using RStudio v1.4.1106 with R v4.1.0. However, when I reached the snake example, specifically the last line, R aborts on me. No issues with installation and no other issues with the rest of the example.

Thanks, Matt

— Reply to this email directly, view it on GitHub https://github.com/hiweller/recolorize_examples/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4DUVTTWMDQYIGSYFEDA7TVNCS7NANCNFSM5XU2UBKQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Hannah Weller PhD Candidate | Dept. of Ecology & Evolutionary Biology | Brown University Phone: (617) 529 6837 Email: @.** Web: hiweller.rbind.io | https://github.com/hiweller | twitter.com/hannahiweller Pronouns*: she/her

mhackett324 commented 2 years ago

Thanks for the quick reply. I decided to move on to the beetles (Ex #4) and ran into the issue again. However, the common thread here is absorbLayer(), but in the beetle example, it crashes if plot = TRUE but not when false. Hope this helps!

hiweller commented 2 years ago

Yep, that was my first guess…that plotting function has been finicky in the past. I might do a hot fix that just switches to a less fancy/intensive plotting method.

On Thu, Jun 2, 2022 at 09:06 mhackett324 @.***> wrote:

Thanks for the quick reply. I decided to move on to the beetles (Ex #4) and ran into the issue again. However, the common thread here is absorbLayer(), but in the beetle example, it crashes if plot = TRUE but not when false. Hope this helps!

— Reply to this email directly, view it on GitHub https://github.com/hiweller/recolorize_examples/issues/1#issuecomment-1144841814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4DUVUACG5G5DUHFK2UXULVNCWWBANCNFSM5XU2UBKQ . You are receiving this because you commented.Message ID: @.***>

--

Hannah Weller PhD Candidate | Dept. of Ecology & Evolutionary Biology | Brown University Phone: (617) 529 6837 Email: @.** Web: hiweller.rbind.io | https://github.com/hiweller | twitter.com/hannahiweller Pronouns*: she/her

hiweller commented 2 years ago

Hi Matt,

Just pushed an update to the development version: https://github.com/hiweller/recolorize/commit/6de5a1e42a74d6e4752b0039b0481d92a676b117

Reinstall recolorize (devtools::install_github("hiweller/recolorize") and try running the examples again. It should work without running into those errors now.

The highlighted patch thing is a neat trick when it works, but I think it just runs up against memory allocation too fast to be of any practical use, so I'm glad you brought this up and motivated me to just switch to the easier plotting method. Let me know if you still run into issues with absorbLayer (or run into any additional bugs)!