hizzlekizzle / quark-shaders

A repository of GLSL #150 pixel shaders for use with byuu's Higan emulation package.
GNU General Public License v2.0
186 stars 27 forks source link

crt-royale-xm29plus #7

Open Max833 opened 3 years ago

Max833 commented 3 years ago

Hello, thanks for your efforts. Amazing shader collection! :D

I would like to use crt-royale-xm29plus with bsnes. Is there a quark-shader for this as well?

hizzlekizzle commented 3 years ago

There is not. It shouldn't be terribly hard to add it, but each one of the royale duplicates adds many MBs to the repo size, so I'm reluctant to add too many. I would also need to port over the color grading LUT shader.

Max833 commented 3 years ago

Thank you for your quick reply! I see. That's a shame, but i totally understand.

I have to more questions regarding the quark-shader crt-royale (with bsnes):

window mode: 1

fullscreen: 2

hizzlekizzle commented 3 years ago

Hmm, looks like the mask is getting scaled some in fullscreen. I'll try to reproduce it and see if I can find a solution.

For the bulge, you can disable it in the settings, which are at the top of each shader pass. I think for this one, you just need the 'geom mode' set to 0 in the last pass: https://github.com/hizzlekizzle/quark-shaders/blob/master/CRT-Royale.shader/geometry-aa-last-pass.fs#L73

Max833 commented 3 years ago

Hmm, looks like the mask is getting scaled some in fullscreen. I'll try to reproduce it and see if I can find a solution.

I think I know what's the reason for that. As soon as I enable aspect correction / overscan and go to the fullscreen mode, this is happening. Is it disabled, everything looks fine. I hope there is a way to fix this. Thank you so much that you are looking at this problem.

For the bulge, you can disable it in the settings, which are at the top of each shader pass. I think for this one, you just need the 'geom mode' set to 0 in the last pass: https://github.com/hizzlekizzle/quark-shaders/blob/master/CRT-Royale.shader/geometry-aa-last-pass.fs#L73

Thank you! It is working. :D

Max833 commented 3 years ago

Maybe this commit broke something for some shaders:

https://github.com/bsnes-emu/bsnes/commit/d9f80db0368a9ff8ec5c8c8fe5bf70a42d70c098

hizzlekizzle commented 3 years ago

that's certainly possible. Can you compile before that commit and see?

Max833 commented 3 years ago

Yes, right now. But it didn't affect this...

Edit: Okay, that's why: ^^;

"target-libretro/libretro.cpp"