search

hjacobs / kube-janitor

Clean up (delete) Kubernetes resources after a configured TTL (time to live)
GNU General Public License v3.0
473 stars 40 forks source link

Provide special value for janitor/ttl that will block wipe process. #38

Closed antban closed 5 years ago

antban commented 5 years ago

Sometimes people use the same file to deploy to different environments (live, staging, pr), as deployments to different stacks may differ only in parameter values (and parameters are taken from config maps or some other template engine). Unfortunately, presence of janitor/ttl forces people to create several yaml files with only difference - presence of janitor/ttl annotation. I believe that ability to set special value (janitor/ttl: undead, for example) that is blocking janitor in specific environments will allow people to create unified deployments.

hjacobs commented 5 years ago

I'm confused by your "undead" example, do you mean something like "TTL: forever"?

antban commented 5 years ago

@hjacobs yes, forever also works, but it's much less fun. If you agree with this feature, I can make PR

hjacobs commented 5 years ago

@antban yes, a PR would be welcome :smile: