hjacobs / kube-janitor

Clean up (delete) Kubernetes resources after a configured TTL (time to live)
GNU General Public License v3.0
473 stars 40 forks source link

At least some version tags in this repo are placed on the wrong commits #56

Open sryabkov opened 4 years ago

sryabkov commented 4 years ago

The 20.2.0 tag is placed on commit f395fbc instead of 86e1dea, which follows it.

When one does git checkout 20.2.0, they get 20.2.0 bits with the 20.1.0 version number

Please see the screenshot

image

It looks like this is an issues that persists throughout versions:

image

I can see three possible remedies:

Others have been confused by this, as can be see in this comment

hjacobs commented 4 years ago

It's actually more or less on purpose, as I first tag/release and afterwards increment versions in the deployment manifests and README. I don't consider this an issue --- e.g. I might release something, test it on some server, and afterwards bump the versions in README/manifests.

sryabkov commented 4 years ago

@hjacobs I figured you didn't consider this to be an issue, otherwise you wouldn't be doing it, but I suspect most (or at least some) people would be tripped by this, that's why I created the issue.