search

hjalmers / angular-generic-table

A generic table for Angular 2+. Generic table uses standard markup for tables ie. table, tr and td elements etc. and has support for expanding rows, global search, filters, sorting, pagination, export to CSV, column clicks, custom column rendering, custom export values.
https://hjalmers.github.io/angular-generic-table/
MIT License
105 stars 55 forks source link

Update linting dependencies #222

Closed mklein994 closed 6 years ago

mklein994 commented 6 years ago

This adds the @angular/language-service, and updates tslint and codelyzer.

It also updates the tslint.json file by copying over the one generated by a new @angular/cli@1.7.4 project.

P.S. Out of curiosity, why did you switch to using prettier?

hjalmers commented 6 years ago

Well I started using prettier in some other projects and really liked it, instead of just letting you know that something is wrong it actually solves the issue on the fly when you save the file (depending how you configure it). I'm going to add an issue to add tslint-config-prettier (thanks for the tip). I removed some of the settings related to formatting from the old and outdated tslint file but I agree that's it's nicer to keep them there if it's possible to solve the conflicts using tslint-config-prettier.

And to answer your other questions on the topic, I have no real preference regarding tabs or spaces as long as it's the same within a project so the change was unintentional and probably due to just copying the standard config for prettier. My thought was to add a pre-commit step and go through all the files in the project and make sure the format is correct, but I haven't gotten that far yet:)