search

hjalmers / angular-generic-table

A generic table for Angular 2+. Generic table uses standard markup for tables ie. table, tr and td elements etc. and has support for expanding rows, global search, filters, sorting, pagination, export to CSV, column clicks, custom column rendering, custom export values.
https://hjalmers.github.io/angular-generic-table/
MIT License
104 stars 55 forks source link

Angular 7 has an issue with dragula from ColumnSettingsModule #285

Closed jackjamieson closed 5 years ago

jackjamieson commented 5 years ago

Currently attempting to move my app to Angular 7. I'm using version 4.17.1 of angular-generic-table

For some reason I had to import DragulaService into my own app module to get this error to actually tell me what was wrong, otherwise it would throw a StaticInjectorError looking for the service. Now it's telling me that

dragulaService.drop.subscribe is not a function coming from angular-generic-table column settings. Really not sure where to go from there.

Maybe has something to do with https://github.com/valor-software/ng2-dragula/blob/master/MIGRATION-v2.md

jackjamieson commented 5 years ago

Downgrading to ng2-dragula v1.5.0 seems to fix this issue. Closing this ticket.