hjanuschka / fastlane-plugin-cryptex

MIT License
36 stars 16 forks source link

Bump keystore expiry to 10000 days #5

Closed kasperg closed 6 years ago

kasperg commented 6 years ago

First of all. Thanks for this fastlane plugin. I am new to both fastlane and Android development but I think it provides a great way to handle keystores.

This PR reflects a recent experience of mine:

If you try to upload an APK signed using the generated keystore to Google Play you get an error saying that the certificate expires too soon.

Bump the expiry date to 10000. This expiry date is taken from the React Native APK signing guide.

hjanuschka commented 6 years ago

ohhh sry took a while until i found that PR 👍 many thx. going to merge it and release a new version (soon)