hjd1964 / OnStep

Arduino telescope goto for equatorial and alt/az mounts
http://www.stellarjourney.com/index.php?r=site/equipment_onstep
GNU General Public License v3.0
452 stars 167 forks source link

Meridian Flip Does not work anymore #187

Closed azwing closed 2 years ago

azwing commented 2 years ago

Howard,

may be I found a typo within OnStep.ino (a minus sign before degreesPastMeridianE) Removing it Meridian Flip works again.

@@ -675,7 +675,7 @@ void loop2() { if (getInstrPierSide() == PierSideWest) { if (getInstrAxis1() > degreesPastMeridianW && (!(autoMeridianFlip && goToHere(true) == CE_NONE))) { generalError=ERR_MERIDIAN; stopSlewingAndTracking(SS_LIMIT_AXIS1_MAX); } } else

azwing commented 2 years ago

After many tests it seems the Meridian flip works after that change even I am not convinced the change is in the right place, it just prevents OnStep from stopping tracking issuing an underpole error.

azwing commented 2 years ago

Afte some other test I discoverd I am stupid, but this is not new :-)

If all what I have understood from Limits seting is that if I set both degreesPastMeridianW and degreesPastMeridianE to the same value Autoflip will never happen.

But If I set degreesPastMeridianE to 4° and degreesPastMeridianW to -4° it works fine.

I am right?

hjd1964 commented 2 years ago

The automatic meridian flip goto destination must be within limits (on the other pier side) or the goto will fail and it'll throw a meridian limit error and stop tracking.

azwing commented 2 years ago

Thank you, I think there is a lot of confusion with this topic and would like to include a help in the Indi driver.

hjd1964 commented 2 years ago

I was just discussing this so you might want to read this topic (copy/paste the url if needed as github doesn't seem to follow links out on the web):

https://onstep.groups.io/g/main/topic/under_the_pole_limit_exceeded/88577635?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,88577635,previd=9223372036854775807,nextid=1643054736055324299&previd=9223372036854775807&nextid=1643054736055324299