hjdhjd / homebridge-ratgdo

🚗 non-myQ Liftmaster, Chamberlain, and Ratgdo Plugin for Homebridge
Other
100 stars 2 forks source link

Konnected GDO Tweaks #18

Closed KyleBoyer closed 4 months ago

KyleBoyer commented 4 months ago

The project_name for connected GDOs has 3 possible values The service version field is called esphome_version on Konnected GDOs

KyleBoyer commented 4 months ago

Another difference I noticed is the firmwareVersion field, here is an example service txt from my device:

{
  web_api: 'true',
  project_version: '1.3.0.6',
  project_name: 'konnected.garage-door-gdov2-q',
  network: 'wifi',
  platform: 'ESP32',
  mac: '64e83...',
  esphome_version: '2024.6.6',
  friendly_name: 'Main GDO'
}

I believe you'll want esphome_version, as project_version auto-increments with each settings change.

hjdhjd commented 4 months ago

I relied on your prior PR for the initial integration. I'll be looking more closely at the Konnected stack with an onhand device prior to merging or implementing any additional changes. Thanks.

KyleBoyer commented 4 months ago

I relied on your prior PR for the initial integration. I'll be looking more closely at the Konnected stack with an onhand device prior to merging or implementing any additional changes. Thanks.

Here is the project_name change that was slightly misinterpreted: https://github.com/hjdhjd/homebridge-ratgdo/pull/16/files#diff-3707fab8a308be41c5fcf860777178103f9352c2efc81da46b8bbc873261c135R128

The version vs esphome_version was discovered afterwards and is much more minor.

hjdhjd commented 4 months ago

Can you provide a bit more clarity on the various GDO types and specific differences in the Konnected world? As I understand it, only one of those GDOs will correctly work as the Ratgdo variant that Konnected is. The others represent other GDO types from Konnected. Can you elaborate (ideally with references to the detail where you know it)?

To elaborate on my end: the service.txt you shared is of the -q variety...do the other variants represent ESPHome-capable versions as well, or something else? It seems that prior releases of the Konnected GDO weren't ESPHome-based?

hjdhjd commented 4 months ago

I'm good with the edits...outside of getting clarity on the project name string for Konnected GDOs...my concern is inadvertently assuming they're truly Ratgdo/ESPHome variants or not. The -q variant, based on what you shared above, seems clearly ESPHome-based...but what're the others?

KyleBoyer commented 4 months ago

Can you provide a bit more clarity on the various GDO types and specific differences in the Konnected world? As I understand it, only one of those GDOs will correctly work as the Ratgdo variant that Konnected is. The others represent other GDO types from Konnected. Can you elaborate (ideally with references to the detail where you know it)?

This article pretty well describes the differences between the V1 and V2 s/q variations: https://community.konnected.io/t/announcing-two-new-garage-door-opener-products-from-konnected/35300

Here is a helpful repo that indicates the exact project_name used: https://github.com/konnected-io/konnected-esphome/blob/master/garage-door-GDOv1-S.yaml https://github.com/konnected-io/konnected-esphome/blob/master/garage-door-GDOv2-Q.yaml https://github.com/konnected-io/konnected-esphome/blob/master/garage-door-GDOv2-S.yaml

KyleBoyer commented 4 months ago

Having reread that article it does only seem like the BlaQ GDO v2 model has ratgdo built in - I'll adjust the PR shortly!

hjdhjd commented 4 months ago

Can you provide a bit more clarity on the various GDO types and specific differences in the Konnected world? As I understand it, only one of those GDOs will correctly work as the Ratgdo variant that Konnected is. The others represent other GDO types from Konnected. Can you elaborate (ideally with references to the detail where you know it)?

This article pretty well describes the differences between the V1 and V2 s/q variations: https://community.konnected.io/t/announcing-two-new-garage-door-opener-products-from-konnected/35300

Here is a helpful repo that indicates the exact project_name used: https://github.com/konnected-io/konnected-esphome/blob/master/garage-door-GDOv1-S.yaml https://github.com/konnected-io/konnected-esphome/blob/master/garage-door-GDOv2-Q.yaml https://github.com/konnected-io/konnected-esphome/blob/master/garage-door-GDOv2-S.yaml

Yep...I came across the same, but only the v2-Q is really associated with the blaQ. I'll tentatively add support for all of them, but I'd really like to see a real person provide feedback on whether it works correctly as expected or not.

hjdhjd commented 4 months ago

Having reread that article it does only seem like the BlaQ GDO v2 model has ratgdo built in - I'll adjust the PR shortly!

I think you've come to the conclusion I was hoping you would. 😄

Stick to what you know works and can test.

hjdhjd commented 4 months ago

Your update PR makes me smile. Thanks for the contribution. 😄 It will be in the next release.

github-actions[bot] commented 3 months ago

This issue is locked to prevent necroposting on closed issues. Please create a new issue for related discussion, if needed.