search

hjeti / vue-skeleton

A Vue skeleton
MIT License
108 stars 21 forks source link

FaviconsWebpackPlugin #100

Open nossienl opened 5 years ago

nossienl commented 5 years ago

when setting this to true, you also need to set title inwebpack.partial.conf.plugins.js if you don't do this it tries to guess the name of app/website thru the function guessAppName and this tries to looks that up in package.json. I don't think everybody changes the package.json to match the website/app name.

maybe we can retreive website title from index.html and set that in webpack.partial.conf.plugins.js

flut1 commented 5 years ago

I don't think using the html is a feasible solution. The title in the html can also be changed at runtime, which won't be picked up yet at build time. My suggestions:

  1. Don't guess the title, but error indicating that you need to add a title
  2. Use the package.json value but error if that still equals "Vue Skeleton". Added advantage is that devs will more often update the name in the package json :)
ThaNarie commented 5 years ago

Having a wrong favicon title is something you might not spot early, so using an automatic value from the package.json might also be dangerous.