search

hjeti / vue-skeleton

A Vue skeleton
MIT License
108 stars 21 forks source link

Default Icon component warning: v-html directive can lead to XSS attack #101

Open misspia opened 5 years ago

misspia commented 5 years ago

When running yarn lint, the following warning message from the template's predefined Icon component persists: Screenshot 2019-10-18 at 13 57 27

Since the component comes with the template, the warning for that line in particular should either be ignored by the linter or resolved

ThaNarie commented 5 years ago

Since we have total control over what goes in there, I think in this case a lint-ignore would be fine.

Are you okay to create a PR for this? :)