search

hjeti / vue-skeleton

A Vue skeleton
MIT License
108 stars 21 forks source link

Device state tracker missing max-width in mediaqueries #84

Closed nicofonseca closed 5 years ago

nicofonseca commented 5 years ago

Heyyyyyyy!!!

Please add X-SMALL mediaquery with max-width of 479px, because it's not working properly in small resolutions on the first load.

screen shot 2018-11-07 at 15 22 41
ThaNarie commented 5 years ago

What doesn't work properly, and why? :D

nicofonseca commented 5 years ago

As there is not a max-width set when you load the site on smaller resolutions the device state tracker returns undefined but then it works when you resize the browser.

screen shot 2018-11-07 at 15 58 28
ThaNarie commented 5 years ago

@jesse-mm Maybe this is something in the DeviceStateTracker?

hjeti commented 5 years ago

I see now it doesn't match anything if your min width is smaller than 480. Will look into it.

ReneDrie commented 5 years ago

That’s indeed the case Hj. Discussed this with Jesse as well a while ago. The proposed fix is perfect I think