search

hjiang / jsonxx

A JSON parser in C++
MIT License
539 stars 175 forks source link

Consider going header-only #19

Open sztomi opened 11 years ago

sztomi commented 11 years ago

Sweeping through the .cc file, I didn't see anything that warranted the separate source file. Easy integration for a library is a very attractive feature, and you can't be easier to integrate than with a single header, the best libraries out there are header-only. Hiding the implementation details can be accomplished with anonymous namespaces.

TheMadButcher commented 11 years ago

When going there, I would even opt to use template classes. This way even less code rolls out into the exe/dll ;)

Anyway, I use the code as a baseclass for my extension classes so it is hidden anyway and template classes are not very effective in this situation.