Device select dropdown in logs page does not have option for "Unidentified devices" resulting in incorrect device filter being applied

hjk789 / NXEnhanced

Adds "quality-of-life" features to NextDNS website for a more practical usability

329 stars 20 forks source link

Device select dropdown in logs page does not have option for "Unidentified devices" resulting in incorrect device filter being applied #69

Closed iAmMrinal0 closed 1 year ago

iAmMrinal0 commented 1 year ago

Screenshot without the extension on Firefox version: 107.0

So when this option isn't shown, selecting a device doesn't show the logs for that device. It shows it for the previous device in the dropdown list.

hjk789 commented 1 year ago

"Unidentified devices" and "Other devices" are the same thing. Maybe I could rename it to the official name.

iAmMrinal0 commented 1 year ago

@hjk789 that's right. It's a mistake on my part. I assumed that the issue is caused by not showing the option. The underlying issue is that selecting the device results in logs for the device above it. For example, refer to this screenshot where device selected is x and logs for device y are shown

I would expect logs of risa to show up but it shows logs for device betazed which is the device above risa in the list.

I tried the extension on Chrome too and it's the same behavior. Let me know if there's any more information I could provide.

hjk789 commented 1 year ago

I tested here and the problem you're reporting is not happening for me. I'll try doing a more in-depth test and I'll update you when done.

hjk789 commented 1 year ago

@iAmMrinal0 I just published a new release that fixes the problem you reported on your last comment. Can you update and test if it's still happening?