Add Ping measurement to Get-SteamServerInfo

hjorslev / SteamPS

Module that utilizes PowerShell as a wrapper for SteamCMD and interacts with various Steam APIs.

https://www.powershellgallery.com/packages/SteamPS

MIT License

69 stars 14 forks source link

Add Ping measurement to Get-SteamServerInfo #101

Closed ericwong3 closed 1 month ago

ericwong3 commented 1 month ago

Description

This PR adds Ping measurement to Get-SteamServerInfo as described in #100

Resolves #100

Type of change

[ ] 📖 [Docs]
[ ] 🪲 [Fix]
[ ] ⚠️ [Security fix]
[ ] ♻️ [Refactor]
[ ] 🎉 [Feature]
[x] ✨ Enhancement
[ ] 🌟 [Breaking change]

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added Pester tests that covers the added cmdlets

hjorslev commented 1 month ago

Thanks for your contribution! I think it looks good. I will just test in on my machine (hopefully tomorrow) and then merge & publish your contribution.

The reason the codecov is failing is because it is a bad / non working Pester test I wrote. I'll fix that later.