Using NetworkCredential to decrypt the secure string instead of marshalling. This method properly handles the unmanaged memory, makes it simpler and correctly frees the unmanaged memory.
Otherwise, if marshalling:
PtrToStringAuto should be PtrToStringBSTR instead to avoid encoding issues.
There should be a finally block in the function that calls [System.Runtime.InteropServices.Marshal]::ZeroFreeBSTR($BSTR) to free the unmanaged memory, otherwise the plain text password lives in unmanaged memory while the pwsh process is alive.
Both points above are correctly managed by NetworkCredential.
Using [System.IO.Path]::PathSeparator instead of ; to split the path in case you want to make this module compatible with Linux in the future (its separator is :). Trim() to remove any extra trailing or leading whitespace from each token and then filtering any token that could be purely white space, i.e.:
PR Summary
Context
Sent the PR to the wrong repo 😅. Also added a few more changes to
Add-EnvPath(the logic could be simplified).Changes
Adding
tools/Modulesandoutputfolder to.gitignore, otherwise the modules needed for CI/CD and the released module would get pushed to repository.Added
launchfile for easier debugging, i.e.: Ctrl+Shift+Enter opens a newpwshwith the module already loaded.Added
tasksfile, easier building, i.e.: Ctrl+Shift+B runsbuild.ps1and F1 ->Run Test Taskrunsbuild.ps1 -Task Test.Using
NetworkCredentialto decrypt the secure string instead of marshalling. This method properly handles the unmanaged memory, makes it simpler and correctly frees the unmanaged memory.Otherwise, if marshalling:
PtrToStringAutoshould bePtrToStringBSTRinstead to avoid encoding issues.finallyblock in the function that calls[System.Runtime.InteropServices.Marshal]::ZeroFreeBSTR($BSTR)to free the unmanaged memory, otherwise the plain text password lives in unmanaged memory while thepwshprocess is alive.Both points above are correctly managed by
NetworkCredential.Using
[System.IO.Path]::PathSeparatorinstead of;to split the path in case you want to make this module compatible with Linux in the future (its separator is:).Trim()to remove any extra trailing or leading whitespace from each token and then filtering any token that could be purely white space, i.e.:Same change to split using
[System.IO.Path]::PathSeparator.Checklist