Mess in sending requests

hjoshi123 / CryptoNews

A small client for the Medium Blog Post

GNU Lesser General Public License v3.0

8 stars 3 forks source link

Mess in sending requests #2

Open gordinmitya opened 5 years ago

gordinmitya commented 5 years ago

You call loadJSON twice: in onCreate and onStart, what is the sense to do that?

The same problem with compositeDisposable – you call it in onStop as well as in onDestroy.

Another thing that there is no any care about configuration changes.

It would be great if you describe reasons or fix problems in project to not confuse readers! Thank you in advance!

hjoshi123 commented 5 years ago

Hey @gordinmitya thanks for the issue. It would be awesome if you could create a PR for the above issue. I would be happy to review it and approve it if its necessary.