hjr3 / soldr

Other
23 stars 2 forks source link

Unable to retry a request that has been retried too many times #53

Closed hjr3 closed 8 months ago

hjr3 commented 8 months ago

Trying to manually retry a request that has been retried a lot will not succeed.

We can see the following log message:

2024-01-19T00:26:59.309193Z WARN soldr::db: request 127747 has been retried 29 times. skipping

This logic was intended to put a limit on how many automatic retries were allowed. We should bypass this check when the retry is being done manually.

hjr3 commented 8 months ago

The request was being retried. When we manually retry, the request is forced back into a state of "created" which will then retry. In my case, the request was still failing and went to be automatically retried. Since it had been retried so many times already, it correctly skipped.

The reason I did not see this working was because the management UI was not showing all of the request attempts. I am fixing this.