hjunleon / pe

0 stars 0 forks source link

Corrupted savefile not guaranteed graceful fail #10

Open hjunleon opened 2 years ago

hjunleon commented 2 years ago

image.png

I've tried adding a bunch of lines to the savefile to simulate a scenario where save file data is corrupted somehow. Aside from failing at an index out of bounds error which exits the program forcefully, the program should be built to invalidate the savefile.

Rationale of marking as high is a user should not be expected to resolve this corrupted savefile issue by themselves. If this file is left in that directory (or not cleared), the program cant be run anymore

image.png

This is an example where the file is indeed corrupted, but file isn't invalidated before parsing. Potentially could load harmful material

soc-se-bot commented 2 years ago

Team's Response

Please provide specific steps so that the team can reproduce the issue. Thank you.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: [replace this with your reason]

Try the following inputs in your savefile (there are 2)

project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff`

project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1`,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1`,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1`,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1`,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1`,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff project1buy textbooks true,false,No deadline specified,false,false,No deadline specified,false,false,No deadline specified,fale,false,No ddline specified,false,false,N deadline specified,false,false,No deadline specified2022-04-03http://github.com/roject1`,java,java,java,java,jav1,_,6tg project2``No deadlinepcifiedhttp://www.github.com/pff` project22``No deadlinspecifiedhttp://www.github.com/pff` project1_1``No deadlipecifiedhttp://www.github.com/pff` project1.___``No deadline specifiedhttp://www.github.com/pff`


:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]

Original reason