search

hjuntan / pe

0 stars 0 forks source link

Limitation of storing people's id with int #5

Open hjuntan opened 2 months ago

hjuntan commented 2 months ago

Storing people using int is fine but at a very large scale, people will be identify starting at some number prefix or the number of people can easily exceed the MAX_INTEGER limit: For example: showrelated i/8000000001 will display a invalid command format error

image.png

nus-pe-script commented 2 months ago

Team's Response

image.png

Guideline states problems caused by integer overflows should not be considered a bug, since this input does not cause harm. However, we agree this might be a case to be considered and handled in future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]