hjuntan / pe

0 stars 0 forks source link

Unknown classes in person class diagram #8

Open hjuntan opened 2 months ago

hjuntan commented 2 months ago

image.png

In the person model class diagram, what are the classes Department; Products; TermsOfServices; Skills, etc. ? You should represent them as separate classes with their own structure

nus-pe-bot commented 2 months ago

Team's Response

As the Client, Supplier, and Employee extends from Person class and does not have many more fields that specifically belongs to each subclass, therefore, it is more readable to just group these Client, Supplier, and Employee classes. Also, as Person is an abstract class in NetConnect, showing limited fields that Person in general could has does not give much practical information. Instead, as a person in NetConnect has to only be categorized into either Client, Supplier, or Employee, we therefore could show what are all the fields that they can have.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, I understand that simplifying the model class diagram to something more readable is better especially when the fields are simple. However, it might cause unnecessary confusion. For example, the Products in both Supplier and Client class.

Also, as Person is an abstract class in NetConnect

Secondly, it is not explicitly mentioned in the class model diagram attached or anywhere else in the DG that Person is an abstract class. My bad.