Pkginfo files with rong values get ignored/not displayed, errors logged 'silently'

hjuutilainen / munkiadmin

macOS app for managing Munki repositories

MIT License

370 stars 34 forks source link

Pkginfo files with rong values get ignored/not displayed, errors logged 'silently' #200

Open arubdesu opened 3 years ago

arubdesu commented 3 years ago

Log is showing an error, it's not crashing, but Slack isn't visible to be modified/interacted with. I have the repo freshly checked out from git into /private/tmp because... I like to live dangerously. On refresh these messages are logged:

2021/06/22 09:13:44:424  Error: Caught exception while reading pkginfo SlackIntel-4.17.0.plist
2021/06/22 09:13:44:425  Error: Caught exception while reading pkginfo Slack-4.17.0.plist
2021/06/22 09:13:44:431  Error: Caught exception while reading pkginfo Slack-4.16.2.plist

hjuutilainen commented 3 years ago

Probably something in unexpected format in those pkginfos. Can you publicly share any of these?

arubdesu commented 3 years ago

Pardon I slid into your MacAdmins Slack DM's with a zip 😅

arubdesu commented 3 years ago

As per convo 'offline', I was setting supported_architectures to a (single) string instead of an array containing strings (as per the wiki. Because bad at computers. 😅

llamafilm commented 4 months ago

I just ran into this same issue. It's interesting that neither autopkg nor makecatalogs complain about this.

arubdesu commented 4 months ago

It's amazing people can ever find answers to questions or explanations of unexpected behavior, hope this was helpful! (It's really not a bug or issue with MunkiAdmin to not bend-over-backwards and handle unexpected inputs.)