search

hjuutilainen / munkiadmin

macOS app for managing Munki repositories
MIT License
371 stars 33 forks source link

Stalls on extracting icons from Adobe CC package #35

Open mikesolin opened 10 years ago

mikesolin commented 10 years ago

Hey Hannes!

Thanks for the MunkiAdmin beta for Munki 2 - I was able to successfully extract icons from nearly all of the packages in my repo. Between the support for icons, categories, and developers, modernizing our repository was quick!

I remembered you mentioning over Twitter that you'd like examples of packages that fail to extract icons. I tried extracting icons from two of our Adobe CC packages (both Bridge and Acrobat) and MunkiAdmin stalled on expanding the package.

Is this something you want to support? I understand the Adobe packages are typically a different situation than other types of packages. Are there any logs I can provide to help?

Thanks!

Mike

hjuutilainen commented 10 years ago

Thanks for reporting. I would like to see MunkiAdmin supporting as many installer types as possible so I'll definitely take a look at this. Are the packages in standard pkg/mpkg format or are they in "Adobe format"? I currently have access to only the consumer versions of Photoshop and Lightroom CC, do you have any idea if their installers have this same problem?

mikesolin commented 10 years ago

I can check! Our Lightroom installer is currently broken, but I'll give it a try with Photoshop. Our repo was too slow today to give it another try, but maybe it'll be faster over the weekend.

I used the Creative Cloud Packager to make these packages, but intend to give aamporter a try instead. Is that what you're using? I think CCP makes them in "Adobe format" - they're pkg/mpkg files that I can import, but my understanding is that it's the postinstall script that does the actual installation.

mikesolin commented 10 years ago

Hmm - I tried twice this weekend, and Photoshop stalled out both times (running for 7+ hours each). Nothing related shows in the logs, but I only enabled debug logging, not logging all properties.

hjuutilainen commented 10 years ago

Sorry for the late reply! Could you try the linked custom build? Keep debug logging on and it should log a lot more about the icon extraction process. Post what you get in logs: https://app.box.com/s/d0vtddzx42fjxpz8w8x0

mikesolin commented 10 years ago

This is going to sound weird, but I don't see anything in the logs after the initial startup.

hjuutilainen commented 10 years ago

And now I see what's happening here. The pkginfo for Adobe CC package you're trying is not a copy_from_dmg type or Apple installer package type but probably one of those custom Adobe types. This was causing MunkiAdmin to display the progress dialog but never actually do anything in the background. The current preview 3 release should error on any installer types it doesn't know about.

I think this is going to be harder to support than I initially thought. I need to get my hands on one of these Adobe installers.